Skip to content

Conversation

@samarthrawat1
Copy link
Contributor

Says 3 distinct but only has 2 listed

@samarthrawat1
Copy link
Contributor Author

@Vidit-Ostwal do you think this is correct?

@samarthrawat1 samarthrawat1 changed the title Update memory.mdx Doc Fix: fixed number of memory types Aug 7, 2025
@Vidit-Ostwal
Copy link
Contributor

@Vidit-Ostwal do you think this is correct?

Yes, I think it's just maintaining the previous documentation order.

@Vidit-Ostwal
Copy link
Contributor

@Vidit-Ostwal do you think this is correct?

Yes, I think it's just maintaining the previous documentation order.

LGTM

@samarthrawat1
Copy link
Contributor Author

So.. you wanna merge this or should I close it? @Vidit-Ostwal

@Vidit-Ostwal
Copy link
Contributor

Vidit-Ostwal commented Aug 7, 2025

So.. you wanna merge this or should I close it? @Vidit-Ostwal

I would love to merge if I get the permission, not a maintainer :)
Wait for a day or say, other maintainers might notice, otherwise tag one of them.

Copy link
Member

@tonykipkemboi tonykipkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samarthrawat1
Copy link
Contributor Author

Hi @tonykipkemboi

Thank you for reviewing. Can you re-run the failed jobs so that we can merge?

@samarthrawat1
Copy link
Contributor Author

@lorenzejay @greysonlalonde @lucasgomide can anyone rerun the failed test? I think that was a temporary internet/pypi issue.

@tonykipkemboi
Copy link
Member

@lorenzejay @greysonlalonde @lucasgomide can anyone rerun the failed test? I think that was a temporary internet/pypi issue.

hi no worries. we'll get to it today.

@samarthrawat1
Copy link
Contributor Author

It happened again ;-;

@tonykipkemboi tonykipkemboi merged commit 6676d94 into crewAIInc:main Sep 9, 2025
69 of 71 checks passed
laulopezreal pushed a commit to laulopezreal/crewAI that referenced this pull request Oct 7, 2025
* Update memory.mdx

* Update memory.mdx

---------

Co-authored-by: Tony Kipkemboi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants